-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out source of partially filled pixels #3
Comments
Probably happening due to the scaling here: Lines 145 to 160 in 6d18932
|
maybe these will be important: only pixelated for chrome and only crisp-edges for firefox |
there may be a compositing mode that is helpful here https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/globalCompositeOperation |
search for "crisp" on this page https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Applying_styles_and_colors maybe need to check that the points on the path all align with pixels? |
If you zoom in on an area that you filled in from a lower zoom level then the edge pixels have clearly been interpolated:
![image](https://user-images.githubusercontent.com/10111092/84726716-7f3fe500-af5b-11ea-99df-f0f2faa4ec64.png)
This is happening either on the scaling up of the image to match the classCanvas size - or on the downsizing of the class canvas to the zoomed image. I think it may be the latter because if I draw while zoomed in it's crisp:
not sure though. Probably ought to look at what the actual arrays look like.
The text was updated successfully, but these errors were encountered: