keybinds: movewindow respect gaps out for floating windows #9360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlerrorthing
approved these changes
Feb 8, 2025
|
why should it though |
|
is that not what gaps_out is supposed to do? |
|
I also agree that movewindow should respect gaps! But I would prefer if it looked at a separate config option, since I personally prefer no gaps for tiling windows (but I do like gaps for floating windows). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
ref #8411
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
for code style, not sure if we prefer
PGAPSOUT->leftorPGAPSOUT.leftdoes not fix the issue with snap that @sand4rt mentioned, i might make another PR for that
Is it ready for merging, or does it need work?
ready