fixes #9322, take active_area_size into account when sending tip event
#9325
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
vaxerski
previously approved these changes
Feb 4, 2025
clamydo
force-pushed
the
fix_pen_cursor_jump
branch
from
b39f466 to
edbc420
Compare
|
I've refactored the transformation in its own function so the code is shared. This makes sure the same transformation is used for both events. Does this work for you? |
vaxerski
reviewed
Feb 5, 2025
clamydo
force-pushed
the
fix_pen_cursor_jump
branch
from
81c3a76 to
c541e7f
Compare
vaxerski
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes #9322. Also fixes #9132 (comment) (so
relative_input = truehas priority).Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
The transformation basically was just copied over from
void CInputManager::onTabletAxis.So perhaps the transformation should be applied instead in
warpAbsolute? I'm not familiar with the codebase. In this revision, the transformation is applied at any position changing event (as far as I understand).Note that when
relative_input = trueis setactive_area_*is ignored. Perhaps in the future both could be combined (but I think the value in having both is low).Is it ready for merging, or does it need work?
It fixes the bug and works for me. But would be cool if somebody could check it; especially if it does not introduce additional issues.