hyprctl: add lastwindowclass to workspaces #9016
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jan 10, 2025
|
While hyprctl clients can be used, I don't understand why there should be the misdirection of including lastwindowtitle in workspaces but not including the class. |
|
because we are trashing the output for no reason imo |
|
The reason I was wanting the change was for getting the icon of the last focused window on all the separate workspaces, maybe I'm using the class wrong, but it seems to align with the app name. I was just confused as to why lastwindowclass wasn't included with hyprctl workspaces. But if you think adding it is too big a breaking change I can just keep self-aligning workspaces and clients output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Just adds the field "lastwindowclass" to the out put of
hyprctl workspacesIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Yes