Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into verkle #8332

Open
wants to merge 136 commits into
base: verkle
Choose a base branch
from

rollback lookupcost modification during oog and fix after review

bbaebfc
Select commit
Loading
Failed to load commit list.
Open

Merge main into verkle #8332

rollback lookupcost modification during oog and fix after review
bbaebfc
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Feb 21, 2025 in 2s

Check failed

There are 27 commits incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 2909ea4 prague fee market for blob gas (#8064) Valid sign-off found
🟢 ffd593d Remove EIP-7742 (#8083) Valid sign-off found
🟢 01126c0 Reimplement EthereumNodeRecord for DNS discovery (... Valid sign-off found
🟢 fa9ca9c Update EIP-2935 (#8066) Valid sign-off found
🔴 4ae3be5 Add GetBodiesFromPeerTask (#8040) No sign-off matches the author or committer
🟢 8448743 Fix guess type for delegate code transactions (#80... Valid sign-off found
🟢 2aadbfc implement the proposed gas changes for bls / eip-2... Valid sign-off found
🟢 0698734 Support code delegations when purging confirmed bl... Valid sign-off found
🟢 8cddcfd Pass miningBeneficiary address to BlockAwareOperat... Valid sign-off found
🟢 85f85da add fallback for parallelization (#8084) Valid sign-off found
🟢 4eb6fb0 Rename accountOverride to stateOverride to match s... Valid sign-off found
🟢 f9776cb Increase the max number of prioritized blob tx in ... Valid sign-off found
🟢 0810b73 Refactor BlockHashOperation block height check int... Valid sign-off found
🟢 1f67cb5 Add back deprecated traceStartBlock methods to the... Valid sign-off found
🔴 9ebba75 Expose head execution time metric (#8092) No sign-off matches the author or committer
🟢 b797f2e log4j conf: replace status (deprecated) with level... Valid sign-off found
🟢 ff5266a add workflow to verify artifacts (#8056) Valid sign-off found
🟢 c4f6f17 Support authorizationList parsing in reference tes... Valid sign-off found
🟢 daf4aae Log calculated world state contents upon state roo... Valid sign-off found
🔴 11a4317 Improve debug_traceBlock calls performance (#8103) No sign-off matches the author or committer
🔴 8308650 Exclude empty requests from requests hash (#8036) No sign-off matches the author or committer
🔴 42b26a4 Move gas refund calculation from MainnetTransactio... No sign-off matches the author or committer
🟢 9c12ed1 handling IllegalArgumentException caused by Discov... Valid sign-off found
🟢 5cc309a Add support for movePrecompileToAddress in State O... Valid sign-off found
🟢 5834afd [CHANGELOG] list deprecated bonsai CLI options (#8... Valid sign-off found
🟢 479bec0 Update EXTCALL creation detection (#8038) Valid sign-off found
🔴 b5fdcc0 Pectra devnet 5: 7702 changes (#8118) No sign-off matches the author or committer
🔴 1e7f6f6 EIP-7623 (#8093) No sign-off matches the author or committer
🟢 870f3b7 default target gas limit for holesky (#8125) Valid sign-off found
🟢 89632d7 Unignore Prague ref tests and remove osakaTime fro... Valid sign-off found
🔴 a98e950 Add baseFeeUpdateFraction to blobSchedule genesis ... No sign-off matches the author or committer
🟢 74d22a0 Revert "Add back deprecated traceStartBlock method... Valid sign-off found
🟢 702ce74 Simulation: Add nonce to call parameter (#8139) Valid sign-off found
🔴 5933a2a Fix rlp validate to handle lists ending at the sta... No sign-off matches the author or committer
🟢 6d05f83 Improve error message for Invalid operation (#814... Valid sign-off found
🔴 e930c2d 8053: Add GetPooledTransactionsFromPeerTask and ap... No sign-off matches the author or committer
🔴 519323f Fix eth_getBlockByNumber with empty params returns... No sign-off matches the author or committer
🔴 e9a94f3 Devnet-5: bug fixes for 7702 (#8148) No sign-off matches the author or committer
🔴 a54c46a Check existence of hardfork milestone to decide if... No sign-off matches the author or committer
🟢 113cf8b Use orElseGet for efficiency, address comment of p... Valid sign-off found
🟢 a1e087d Move p2p host validation to CLI validation (#8158) Valid sign-off found
🔴 7840e8b rename methods and variables, clarify comments (#8... No sign-off matches the author or committer
🔴 8bc9e3f fixes syntax errors (#8164) No sign-off matches the author or committer
🔴 09581ea Pectra testnet fork slots (#8163) No sign-off matches the author or committer
🟢 b150b10 Check if discovery service is running before `admi... Valid sign-off found
🟢 846e483 update eth_call error message (#8129) Valid sign-off found
🟢 b3192a5 Refactor the methods for getting mutable states in... Valid sign-off found
🟢 b5d507d Extend simulate transaction on pending block plugi... Valid sign-off found
🟢 4b8d935 debug_traceBlock use existing block header instead... Valid sign-off found
🔴 e2318fb fixes warning on sonar analysis (#8193) No sign-off matches the author or committer
🟢 0eaad3e add spotless to PR checklist (#8185) Valid sign-off found
🟢 98bed38 Reuse constant INVALID_PARAMS_ERROR_CODE for RpcEr... Valid sign-off found
🟢 6af23ea Improve BLOCKHASH Short Circuit (#8171) Valid sign-off found
🟢 5ac3247 TransactionResult: add v for blob and pending tx (... Valid sign-off found
🟢 ccd3582 Prague t8n and referenceTests fixes for EEST (#816... Valid sign-off found
🟢 57454cb Fix: Remove System.out.println in BytesTrieSet… ... Valid sign-off found
🟢 97a69b0 Devnet5 Fix requests tests (#8201) Valid sign-off found
🟢 68665db Fix code delegation issue found in pectra devnet (... Valid sign-off found
🟢 e984126 Prague Devnet5 - EIP2935 - Fix edge case when the ... Valid sign-off found
🔴 cf7d054 devnet-6: 7702 changes for EXTCODE* (#8169) No sign-off matches the author or committer
🟢 ac0265f devnet-6 system contract addresses update (#8209) Valid sign-off found
🟢 81e1ab9 Round change upon f+1 RC messages (experimental op... Valid sign-off found
🔴 56e5b3c Init KZG precompile contract before importing bloc... No sign-off matches the author or committer
🟢 6d51821 [MINOR] add newline to beginning of PR template (#... Valid sign-off found
🟢 8d360a3 Simulation: Add state to StateOverride (eth_cal... Valid sign-off found
🟢 2412586 7582: Add naive RLP caching for BlockHeader, Trans... Valid sign-off found
🟢 47a5efc EIP-7702 Skip CodeDelegation processing for invali... Valid sign-off found
🟢 a94f376 Treat timestamp as unsigned long in engine api for... Valid sign-off found
🟢 4fa9f0c Add a tx selector to skip txs from the same sender... Valid sign-off found
🟢 24e2895 Fix the simulation of txs with future nonce (#8215... Valid sign-off found
🟢 d691f45 Stop all sub processes spawn by acceptance tests (... Valid sign-off found
🟢 a2ef71b disable flaky test classes (#8239) Valid sign-off found
🟢 5534d65 Revert "Stop all sub processes spawn by acceptance... Valid sign-off found
🟢 4dbb723 Qbft block type (#8142) Valid sign-off found
🟢 2924de0 Invalidate engine_newPayloadV3 if it contains exec... Valid sign-off found
🟢 cb5c223 Use 9 for max blobs when sizing BlobCache (#8222) Valid sign-off found
🟢 e006bbf [TESTING] disable flaky fast sync actions test (#8... Valid sign-off found
🟢 90df5e5 Not all invalid transient not selected txs should ... Valid sign-off found
🔴 b74a7f2 add Xchain-pruning-blocks-retained must be >= epoc... No sign-off matches the author or committer
🟢 214673c Add transaction hash for debug trace responses (#8... Valid sign-off found
🟢 28dd49e [CHANGELOG] add upcoming breaking changes to unrel... Valid sign-off found
🟢 1e5fb00 update rpc gas cap default to 50M (#8251) Valid sign-off found
🟢 630a8f7 EIP2935 - Use system call instead of direct storag... Valid sign-off found
🟢 a818793 Use PendingTransaction interface in block creation... Valid sign-off found
🟢 b24ff90 Remove PostMergeContext singleton (#8253) Valid sign-off found
🟢 952deb7 Prague times for holesky and sepolia (#8255) Valid sign-off found
🟢 2680901 Prague Engine API validation fixes (#8250) Valid sign-off found
🔴 d65b525 Configurable Storage Factory in ThreadBesuNodeRunn... Sign-off not found
🔴 28c3df8 Update prague timestamps for Holesky and Sepolia (... No sign-off matches the author or committer
🟢 e835cd0 bump besu-native to 1.1.2 (#8264) Valid sign-off found
🟢 a021fea Change Qbft to use its own QbftBlockHeader type (#... Valid sign-off found
🟢 08e3427 Serialize CodeDelegation in RPCs (#8265) Valid sign-off found
🟢 cbabf87 Rotate changelog for 25.2.0 (#8266) Valid sign-off found
🟢 72a4e4a Simulation - Expose BlockHashLookup to BlockSimula... Valid sign-off found
🔴 a45475d Update netty to 4.1.118 for CVE-2025-24970 (#8275) No sign-off matches the author or committer
🟢 80a8662 Rebalance GHA runners (#8227) Valid sign-off found
🟢 4e152b0 Split long running DetermineCommonAncestorTaskPara... Valid sign-off found
🟢 4519cd0 chore: add missing RPC method debug_accountRange (... Valid sign-off found
🟢 3638944 Make prague evm spec ready (#8277) Valid sign-off found
🟢 f3bbb90 Add TLS/mTLS options and configure the GraphQL HTT... Valid sign-off found
🔴 af842eb Update to Consensys/discovery 25.2.0 (#8278) No sign-off matches the author or committer
🟢 09a18c8 [CHANGELOG] fixed changelog errors (#8279) Valid sign-off found
🟢 0ad85ec Hotfix for gradle compile issue by locking in json... Valid sign-off found
🟢 428a638 Allow plugins to propose transactions during block... Valid sign-off found
🟢 9d33e95 Revert "Hotfix for gradle compile issue by locking... Valid sign-off found
🟢 fa19459 Use dynamic gas calculator to calculate currentBlo... Valid sign-off found
🔴 90015fc Refactor packet classes for dependency injection (... No sign-off matches the author or committer
🟢 6342f5d RPC - eth_getLogs: Return block not found instead ... Valid sign-off found
🟢 c34e396 allow disabling of transaction indexing while sync... Valid sign-off found
🟢 46e74d1 Stop all sub processes spawn by acceptance tests (... Valid sign-off found
🟢 6791c5f remove k8s NAT method (#8289) Valid sign-off found
🟢 7e25c00 [build] workflows to run for merge queue (#8302) Valid sign-off found
🟢 a3153eb [build] run workflows on merge group event (#8303) Valid sign-off found
🟢 88b6670 Deprecation warning for pre-Byzanthium block creat... Valid sign-off found
🟢 ccb23ab Fix the cleanup of subprocesses after each AT (#83... Valid sign-off found
🟢 b4e7dba upgrade web3j plugins (#8296) Valid sign-off found
🟢 5bf7ae1 [build] Update to gradle 8.11 (#8294) Valid sign-off found
🟢 1508b5c [build] update use of gradle deprecated features (... Valid sign-off found
🟢 873971a update dependency versions (#8293) Valid sign-off found
🟢 efcefad Remove QbftBlockHashing as this is provided by the... Valid sign-off found
🟢 41a0647 Improve Conflict Detection in Parallelization by C... Valid sign-off found
🟢 5304006 [build] update non-bom dependencies (#8315) Valid sign-off found
🔴 2c9446d ephemery genesis - cancun and prague blob config u... No sign-off matches the author or committer
🟢 e8a4755 update base image for evmtool Dockerfile (#8304) Valid sign-off found
🟢 0db6ebc Remove unused qbft core dependencies (#8319) Valid sign-off found
🟢 1cbdcdb [build] evmtool Dockerfile - update apt-get packag... Valid sign-off found
🔴 18e3917 increase mainnet & Sepolia gas limit to 36M (#8249... No sign-off matches the author or committer
🟢 984173e update some deprecated references (#8314) Valid sign-off found
🟢 c1c3715 Upgrade to execution-spec-tests version 4.0.0 (#83... Valid sign-off found
🟢 955cd82 merge main c1c3715... Skipped: sign-off not required in merge commit
🟢 928f10f clean and fix build Valid sign-off found
🟢 8b9dfa0 fix block hash processor for devnet Valid sign-off found
🟢 36fbcdd fix pipeline and reference tests Valid sign-off found
🟢 6a97700 fix block hash operation test Valid sign-off found
🟢 34b96e9 fix readFrom of the BlockHeader class Valid sign-off found
🟢 bbaebfc rollback lookupcost modification during oog and fi... Valid sign-off found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

No sign-off matches the author or committer

A valid sign-off was found in the commit message, but it doesn't match neither the author nor the committer. Make sure that both the name and email in the sign-off line match the author or committer of the commit.

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~136 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin verkle-branch/merge-main