Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Clean up ESLint warnings #1215

Merged

Conversation

syamsudotdev
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Clean up ESLint warnings down to 67 warnings

How did you implement / how did you fix it

  1. Use Joi library to validate types
  2. Apply suggestions from ESLint

How to test

  1. npm test
  2. npm pack && npm i -g hyperjumptech-monika-*.tgz
  3. monika

@syamsudotdev syamsudotdev self-assigned this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (63ccdf8) 63.67% compared to head (d4a7f30) 63.70%.

Files Patch % Lines
src/components/config/parse-insomnia.ts 73.91% 3 Missing and 3 partials ⚠️
packages/notification/channel/instatus/database.ts 20.00% 4 Missing ⚠️
packages/notification/channel/whatsapp.ts 0.00% 4 Missing ⚠️
src/components/config/create-config.ts 0.00% 2 Missing ⚠️
src/components/config/parse-har.ts 84.61% 1 Missing and 1 partial ⚠️
packages/notification/utils/authorization.ts 75.00% 0 Missing and 1 partial ⚠️
src/components/config/index.ts 50.00% 1 Missing ⚠️
src/components/config/parse-postman.ts 94.44% 1 Missing ⚠️
src/components/logger/history.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
+ Coverage   63.67%   63.70%   +0.02%     
==========================================
  Files         111      111              
  Lines        3207     3237      +30     
  Branches      544      551       +7     
==========================================
+ Hits         2042     2062      +20     
- Misses        990      998       +8     
- Partials      175      177       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syamsudotdev syamsudotdev merged commit d35dc5e into hyperjumptech:main Dec 19, 2023
6 checks passed
@syamsudotdev syamsudotdev deleted the chore/cleanup-eslint-warns branch December 19, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants