Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1212 Update github action libraries #1213

Merged

Conversation

sapiderman
Copy link
Contributor

@sapiderman sapiderman commented Dec 14, 2023

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Implements Update ci/cd workflow libraries #1212
  2. Make the github/action workflow versions teh same

How did you implement / how did you fix it

  1. Updated to latest version for each action
  2. In most cases the new versions uses newer node20 runtimes
  3. Updated toolkit for docker actions
  4. Update internal dependencies for various actions

How to test

  1. Click on action and trigger the workflow_dispatch
  2. Or use github.com/nectos/act act -W .github/workflow/nodejs.yaml

image

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86ca6c4) 63.64% compared to head (acf8fad) 63.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files         111      111           
  Lines        3207     3207           
  Branches      544      544           
=======================================
  Hits         2041     2041           
  Misses        990      990           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dennypradipta dennypradipta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sapiderman sapiderman merged commit bdb4855 into hyperjumptech:main Dec 18, 2023
6 checks passed
@sapiderman sapiderman deleted the chore/1212-update-action-libs branch December 18, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants