New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fail body to be string to handle symon error #1

Closed

raosan wants to merge 1 commit into main from fix/symon-error

raosan commented Jan 19, 2024 •

edited

Loading

This is a quick fix to handle error when sending incident email in symon. Change the body to string will fix it

*need further digging in symon part also


          Update status-simulator.ts

3af5808

raosan requested a review from dennypradipta

January 19, 2024 12:16

Collaborator

dennypradipta commented May 2, 2024

I don't think this is the solution for this. It needs to be handled in Symon.

What if the response 500 is indeed returning JSON? We never know. Maybe we need to fix this in Symon instead to make it Yup.mixed().nullable()

I am closing this PR because it does not seem to be the problem

dennypradipta closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet