Avoid the server shutdown by throwing exceptions.

hyperf · Sep 30, 2023 · 1b5e32e · 1b5e32e
1 parent fa48cab
commit 1b5e32e
Showing 1 changed file with 21 additions and 7 deletions.
diff --git a/src/SafeSocket.php b/src/SafeSocket.php
@@ -15,14 +15,18 @@
 use Hyperf\Engine\Contract\SocketInterface;
 use Hyperf\Engine\Exception\SocketClosedException;
 use Hyperf\Engine\Exception\SocketTimeoutException;
+use Psr\Log\LoggerInterface;
 use Swoole\Coroutine\Socket;
+use Throwable;
 
 class SafeSocket implements SocketInterface
 {
     protected Channel $channel;
 
     protected bool $loop = false;
 
+    protected ?LoggerInterface $logger = null;
+
     public function __construct(protected Socket $socket, int $capacity = 65535, protected bool $throw = true)
     {
         $this->channel = new Channel($capacity);
@@ -93,6 +97,12 @@ public function close(): bool
         return $this->socket->close();
     }
 
+    public function setLogger(?LoggerInterface $logger): static
+    {
+        $this->logger = $logger;
+        return $this;
+    }
+
     protected function loop(): void
     {
         if ($this->loop) {
@@ -102,15 +112,19 @@ protected function loop(): void
         $this->loop = true;
 
         Coroutine::create(function () {
-            while (true) {
-                $data = $this->channel->pop(-1);
-                if ($this->channel->isClosing()) {
-                    return;
-                }
+            try {
+                while (true) {
+                    $data = $this->channel->pop(-1);
+                    if ($this->channel->isClosing()) {
+                        return;
+                    }
 
-                [$data, $timeout] = $data;
+                    [$data, $timeout] = $data;
 
-                $this->socket->sendAll($data, $timeout);
+                    $this->socket->sendAll($data, $timeout);
+                }
+            } catch (Throwable $exception) {
+                $this->logger?->critical((string) $exception);
             }
         });
     }