ci: adding macos build to the pipeline #1470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds macOS build support to the CI pipeline but contains critical configuration gaps that need to be addressed.
- Missing
yarn build:maccommand and corresponding build step in both.github/workflows/release.ymland.github/workflows/build.yml .github/workflows/build.ymlincorrectly restricts matrix to onlymacos-latestwhile retaining Windows/Linux build steps.github/workflows/release.ymlattempts to upload macOS artifacts without proper build configuration- Environment variables for macOS builds need to be properly configured in both workflow files
- Artifact paths need validation for macOS-specific file types (
.dmg)
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
.github/workflows/build.yml
Outdated
| @@ -10,7 +10,7 @@ jobs: | |||
| build: | |||
| strategy: | |||
| matrix: | |||
| os: [windows-latest, ubuntu-latest] | |||
| os: [macos-latest] | |||
There was a problem hiding this comment.
logic: Removing Windows and Ubuntu builds while keeping their build steps will result in failed builds. Either restore all OS targets or remove unused build steps.
Suggested change
| os: [macos-latest] | |
| os: [macos-latest, windows-latest, ubuntu-latest] |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content: