feat: torbox integration #1439
Merged
feat: torbox integration #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/renderer/src/constants.ts # src/shared/constants.ts
# Conflicts: # src/locales/en/translation.json # src/locales/pt-BR/translation.json # src/main/entity/user-preferences.entity.ts # src/main/events/auth/sign-out.ts # src/main/knex-client.ts # src/main/main.ts # src/main/services/download/download-manager.ts # src/main/services/process-watcher.ts # src/renderer/src/pages/downloads/download-group.tsx # src/types/index.ts # src/types/torbox.types.ts
# Conflicts: # src/renderer/src/pages/downloads/download-group.tsx
# Conflicts: # src/renderer/src/constants.ts # src/shared/constants.ts
4 tasks
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
(updates since last review)
This PR integrates TorBox as a new download source in Hydra Launcher while modifying the save game upload functionality and removing PixelDrain filename fetching.
- Added TorBox client integration in
src/main/services/download/download-manager.tswith newgetDownloadInfomethod for handling TorBox-specific downloads - Removed direct PixelDrain API calls and simplified to use CDN worker URL in download manager
- Modified
uploadSaveGameinsrc/main/events/cloud-save/upload-save-game.tsto be a local function instead of exported - Added tar archive creation and upload functionality for game save backups with proper cleanup
- Streamlined download payload handling by removing unnecessary axios dependency
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+338
to
+339
| if (!url) return; | ||
| return { |
There was a problem hiding this comment.
logic: Missing error handling when url is undefined. Should throw an error with meaningful message like other downloaders do.
Suggested change
| if (!url) return; | |
| return { | |
| if (!url) throw new Error("Failed to get download URL from TorBox"); | |
| return { |
|
This was referenced Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.