Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"depthFrom" setting ignored for section numbering (since v2.1.0?) #18

Open
awesometown opened this issue Dec 3, 2019 · 5 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@awesometown
Copy link

Section 3.2 of the README.md says "Tips:Section of header is begin with depthFrom", and the image shows header numbers being generated starting at the second level. That is, with depthFrom:2 and given the input:

# Title
## Section
### Subsection

I would expect output:

# Title
## 1. Section
### 1.1 Subsection

It appears things worked this way in version 2.0.0, but as far as I can tell stopped working in 2.1.0. Given the same input as above, the output in all newer versions is:

# 1. Title
## 1.1 Section
### 1.1.1 Subsection
@huntertran huntertran added the bug Something isn't working label Dec 9, 2019
@huntertran
Copy link
Owner

I will comeback to this on this holiday

@damianh
Copy link

damianh commented Feb 4, 2020

This is an annoying regression. Look forward to a fix.

Is it possible to install a previous version?

@terrisgit
Copy link

Adding numbers seems to be broken in the current release. I've tried "insert/update sections" in addition to generating the TOC. I'm not getting any section numbers. From is 1 and To is 6.

@livepdm
Copy link

livepdm commented Feb 28, 2020

I have solved this issue.
because usually only one header at level 1. so I changed the code to force the order action start from level 2 or deeper level.

I forked 3.0.3 and push this repos. but it seems not takes effect.

I'm a beginner of Git, please contact me at alex#livepdm.com if needed.

@huntertran huntertran added this to the v3.1.0 milestone Mar 3, 2020
@huntertran
Copy link
Owner

@livepdm Thank you for your work 😄 . You edited a number of files. I need to test them carefully before merge to master branch. Currently, I busy with my studies. I will come back to this when I have spare time.

@huntertran huntertran self-assigned this Jul 9, 2020
SayCV added a commit to SayCV/markdown-toc that referenced this issue Jan 14, 2022
SayCV added a commit to SayCV/markdown-toc that referenced this issue Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants