Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate alerts #164

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

fjerlov-cs
Copy link
Contributor

@fjerlov-cs fjerlov-cs commented Jun 26, 2024

Adds aggregate-alerts to humio/cli

➜  cli git:(fjerlov/aggregate-alert) ✗ ./bin/humioctl aggregate-alerts
Manage aggregate alerts

Usage:
  humioctl aggregate-alerts [command]

Available Commands:
  export      Export a aggregate alert <aggregate-alert> in <view> to a file.
  install     Installs a aggregate alert in a view
  list        List all aggregate alerts in a view.
  remove      Removes a aggregate alert.
  show        Show details about a aggregate alert in a view.
/Users/fjerlov/Library/Caches/JetBrains/GoLand2023.3/tmp/GoLand/___list aggregate-alerts list DemoView
                 ID                |      NAME       |  DESCRIPTION  | ACTION NAMES | LABELS | ENABLED | THROTTLE FIELD | THROTTLE TIME SECONDS | SEARCH INTERVAL SECONDS | QUERY TIMESTAMP TYPE | TRIGGER MODE  |      RUN AS USERID       | QUERY OWNERSHIP TYPE  
+----------------------------------+-----------------+---------------+--------------+--------+---------+----------------+-----------------------+-------------------------+----------------------+---------------+--------------------------+----------------------+
  SvhhCj21ZV9dRkQd0FBohuCeUVQly77a | aggregate-alert | asdakmsdasd-2 | testing      | label2 | false   | asd            |                  7200 |                    7200 | EventTimestamp       | ImmediateMode | pMeYeiIlF3NljnMAIcEcRnUK | User                  
/Users/fjerlov/Library/Caches/JetBrains/GoLand2023.3/tmp/GoLand/___show aggregate-alerts show DemoView aggregate-alert
                       ID | SvhhCj21ZV9dRkQd0FBohuCeUVQly77a  
                     Name | aggregate-alert                   
              Description | asdakmsdasd-2                     
             Query String | foo=* bar=* | count()             
  Search Interval Seconds | 7200                              
                  Actions | testing                           
                   Labels | label2                            
                  Enabled | false                             
           Throttle Field | asd                               
    Throttle Time Seconds | 7200                              
     Query Timestamp Type | EventTimestamp                    
             Trigger Mode | ImmediateMode                     
           Run As User ID | pMeYeiIlF3NljnMAIcEcRnUK          
     Query Ownership Type | User                              

Process finished with the exit code 0

aggregate-alert.yaml

name: aggregate-alert
description: asdakmsdasd-2
queryString: foo=* bar=* | count()
searchIntervalSeconds: 7200
actionNames:
- testing
labels:
- label2
enabled: false
throttleField: asd
throttleTimeSeconds: 7200
queryOwnershipType: User
triggerMode: ImmediateMode
queryTimestampType: EventTimestamp
runAsUserId: pMeYeiIlF3NljnMAIcEcRnUK

@fjerlov-cs fjerlov-cs requested a review from a team as a code owner June 26, 2024 08:19
@fjerlov-cs fjerlov-cs marked this pull request as draft June 26, 2024 08:22
@fjerlov-cs fjerlov-cs force-pushed the fjerlov/aggregate-alert branch 2 times, most recently from 66b05d9 to 8020f95 Compare June 26, 2024 08:28
@fjerlov-cs fjerlov-cs marked this pull request as ready for review June 26, 2024 08:28
Copy link
Contributor

@jespermbyskov jespermbyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/humioctl/aggregate_alerts_export.go Outdated Show resolved Hide resolved
cmd/humioctl/aggregate_alerts_install.go Outdated Show resolved Hide resolved
cmd/humioctl/aggregate_alerts_remove.go Outdated Show resolved Hide resolved
cmd/humioctl/aggregate_alerts_show.go Outdated Show resolved Hide resolved
@fjerlov-cs fjerlov-cs force-pushed the fjerlov/aggregate-alert branch from 8020f95 to 490523d Compare June 27, 2024 13:43
@fjerlov-cs fjerlov-cs force-pushed the fjerlov/aggregate-alert branch from 490523d to a77cce6 Compare June 28, 2024 08:51
@fjerlov-cs fjerlov-cs force-pushed the fjerlov/aggregate-alert branch 2 times, most recently from 62faeff to 6394e47 Compare July 12, 2024 07:02
@fjerlov-cs fjerlov-cs force-pushed the fjerlov/aggregate-alert branch from 6394e47 to b309232 Compare July 12, 2024 07:04
api/aggregate-alerts.go Outdated Show resolved Hide resolved
api/aggregate-alerts.go Outdated Show resolved Hide resolved
api/aggregate-alerts.go Show resolved Hide resolved
cmd/humioctl/aggregate_alerts_export.go Show resolved Hide resolved
cmd/humioctl/aggregate_alerts_export.go Show resolved Hide resolved
cmd/humioctl/aggregate_alerts_show.go Show resolved Hide resolved
@fjerlov-cs
Copy link
Contributor Author

@danielamkaer with the new changes:

show:

/Users/fjerlov/Library/Caches/JetBrains/GoLand2024.1/tmp/GoLand/___show aggregate-alerts show DemoView aggregate-alert
                       ID | hooUSUSV36H3TP9VXJzi69ix55EaoYGQ  
                     Name | aggregate-alert                   
              Description | test 2 3                          
             Query String | foo=* bar=2 | count()             
  Search Interval Seconds | 3600                              
                  Actions | testaction, testing               
                   Labels | label1, label2, label3            
                  Enabled | true                              
           Throttle Field | test                              
    Throttle Time Seconds | 3600                              
     Query Timestamp Type | IngestTimestamp                   
             Trigger Mode | ImmediateMode                     
           Run As User ID |                                   
     Query Ownership Type | Organization     

export:

name: aggregate-alert
description: test 2 3
queryString: foo=* bar=2 | count()
searchIntervalSeconds: 3600
actionNames:
- testaction
- testing
labels:
- label1
- label2
- label3
enabled: true
throttleField: test
throttleTimeSeconds: 3600
queryOwnershipType: Organization
triggerMode: ImmediateMode
queryTimestampType: IngestTimestamp

List:

/Users/fjerlov/Library/Caches/JetBrains/GoLand2024.1/tmp/GoLand/___list aggregate-alerts list DemoView
                 ID                |      NAME       | DESCRIPTION |    ACTION NAMES     |         LABELS         | ENABLED | THROTTLE FIELD | THROTTLE TIME SECONDS | SEARCH INTERVAL SECONDS | QUERY TIMESTAMP TYPE | TRIGGER MODE  | RUN AS USERID | QUERY OWNERSHIP TYPE  
+----------------------------------+-----------------+-------------+---------------------+------------------------+---------+----------------+-----------------------+-------------------------+----------------------+---------------+---------------+----------------------+
  hooUSUSV36H3TP9VXJzi69ix55EaoYGQ | aggregate-alert | test 2 3    | testaction, testing | label1, label2, label3 | true    | test           |                  3600 |                    3600 | IngestTimestamp      | ImmediateMode |               | Organization          


@danielamkaer danielamkaer merged commit 4d23462 into humio:master Jul 12, 2024
4 checks passed
@fjerlov-cs fjerlov-cs deleted the fjerlov/aggregate-alert branch August 1, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants