Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create service-account only when needed #8

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: create service-account only when needed #8

merged 1 commit into from
Feb 14, 2024

Conversation

johanneswuerbach
Copy link
Contributor

Create the gcp-service-account only when the workload has policies.

@johanneswuerbach johanneswuerbach requested a review from a team as a code owner February 13, 2024 17:14
mateuszjenek
mateuszjenek approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@mateuszjenek mateuszjenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanneswuerbach johanneswuerbach merged commit 8502811 into humanitec-architecture:main Feb 14, 2024
1 check passed
@johanneswuerbach johanneswuerbach deleted the cond-account branch February 14, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszjenek mateuszjenek mateuszjenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanneswuerbach @mateuszjenek