-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍟 [SFT] Handles the dataset if it has been preprocessed #2863
Conversation
Thanks for fixing it! |
Added test:
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BenasdTW ! can be merged as soon as the CI is green
* return dataset if it's preprocessed * add is_processed flag variable * add test * move test_sft_trainer_directly_with_pretokenized_data to Tester2 * Update sft_trainer.py * no need for padding and truncation * minor reorganization * Update trl/trainer/sft_trainer.py * let the collator pad * style * fix tests --------- Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com> Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> Co-authored-by: Quentin Gallouédec <quentin.gallouedec@huggingface.co>
Thanks for the kind contribution. Wondering why
would generate new dataset fingerprint now, and not be able to utilize prior cache? All prior steps could utilize the cache with same fingerprint without problem. Many thanks. |
What does this PR do?
Fixes #2861
Adding back the code in SFTTrainer that properly handles the dataset if it has been preprocessed.
This part of the code was removed in #2405, but it should not have been removed.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.