Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whiten_rewards parameter in RLOO config is not used. #2665

Open
5 tasks done
velezbeltran opened this issue Jan 26, 2025 · 0 comments
Open
5 tasks done

whiten_rewards parameter in RLOO config is not used. #2665

velezbeltran opened this issue Jan 26, 2025 · 0 comments
Labels
🐛 bug Something isn't working 🏋 RLOO Related to RLOO

Comments

@velezbeltran
Copy link

Reproduction

Hello!

I think there is a small bug. I was trying to find out what the difference was between the whiten_rewards and normalize_rewards parameter in the RLOOConfig object and after inspecting the code for the RLOOTrainer class I found that it is not used. Hence, I think it should probably be removed.

Image

Thank you for your help and the codebase! It is super helpful.

System Info

I can see this in the codebase.

Checklist

  • I have checked that my issue isn't already filed (see open issues)
  • I have included my system information
  • Any code provided is minimal, complete, and reproducible (more on MREs)
  • Any code provided is properly formatted in code blocks, (no screenshot, more on code blocks)
  • Any traceback provided is complete
@github-actions github-actions bot added 🏋 RLOO Related to RLOO 🐛 bug Something isn't working labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🏋 RLOO Related to RLOO
Projects
None yet
Development

No branches or pull requests

1 participant