Add missing match
on onnx/model.onnx
download
#472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a missing
match
statement within thedownload_onnx
function as it was missing for theonnx/model.onnx
download, leading to an unexpected logging message claiming that the ONNX files were downloaded successfully, while those were not indeed (see attachment at huggingface/Google-Cloud-Containers#132 (comment)).This PR fixes a non-breaking issue, as even if the logging messages were misleading the behaviour for rolling back to
safetensors
if ONNX weights were not available is working as expected.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@OlivierDehaene