Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcodes num_processes to 7 when using vllm #264

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

edbeeching
Copy link
Collaborator

Previously we were using the world size, but when we use vllm for generation we only use 7 devices for optimization, and hence require 7 processes. Should be updated if we scale to multi-node.

@edbeeching edbeeching requested a review from lewtun February 10, 2025 10:23
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small suggestion to make it more generic

@edbeeching edbeeching merged commit cabf275 into main Feb 10, 2025
1 check passed
@edbeeching edbeeching deleted the fix-slurm-n-proc branch February 10, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants