[GRPO] add cosine reward #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgallouedec
reviewed
Feb 6, 2025
edbeeching
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
LGTM, will probably need to be moved around if #144 is merged before this one.
|
yes will wait till that is merged and then move it |
Sorry, some linting errors it looks like, I'll get the fix in ~2 hours |
|
The #144 is ready to ship |
qgallouedec
approved these changes
Feb 6, 2025
|
i'm fixing the merge conflicts |
kashif
force-pushed
the
cosine-rewards
branch
from
97d5670 to
2e73e71
Compare
GitMonkey0
pushed a commit
to GitMonkey0/open-r1
that referenced
this pull request
Feb 24, 2025
* add cosine reward * fix merge * fix typo * fix check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the cosine reward from the paper: https://arxiv.org/pdf/2502.03373