Prevent from "Cannot read properties of undefined" if responseTime or…

… responseSize is missing. Second try.
hudeldudel · May 14, 2024 · 7683d3f · 7683d3f
1 parent 6ec600a
commit 7683d3f
Showing 1 changed file with 23 additions and 19 deletions.
diff --git a/prober/prober.js b/prober/prober.js
@@ -112,26 +112,30 @@ class Prober {
           });
 
           for (const [key, execution] of Object.entries(summary.run.executions)) {
-            // response time
-            if (execution.response.responseTime !== undefined) {
-              responseTimeGauge.set(
-                {
-                  'iteration': execution.cursor.iteration,
-                  'position': execution.cursor.position,
-                  'request_name': execution.item.name
-                },
-                execution.response.responseTime / 1000);
-            }
+
+            if (execution.response) {
+              // response time
+              if (execution.response.responseTime) {
+                responseTimeGauge.set(
+                  {
+                    'iteration': execution.cursor.iteration,
+                    'position': execution.cursor.position,
+                    'request_name': execution.item.name
+                  },
+                  execution.response.responseTime / 1000);
+              }
+
+              // response size
+              if (execution.response.responseSize) {
+                responseSizeGauge.set(
+                  {
+                    'iteration': execution.cursor.iteration,
+                    'position': execution.cursor.position,
+                    'request_name': execution.item.name
+                  },
+                  execution.response.responseSize);
+              }
 
-            // response size
-            if (execution.response.responseSize !== undefined) {
-              responseSizeGauge.set(
-                {
-                  'iteration': execution.cursor.iteration,
-                  'position': execution.cursor.position,
-                  'request_name': execution.item.name
-                },
-                execution.response.responseSize);
             }
 
             // assertions