Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-1131, CAT-1133, CAT-1134 - More cellpop fixes #3685

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

This PR fixes the following issues:

  • The bottom metadata value bars are less likely to overlap with the metadata value label (CAT-1131)
  • The plot controls drawer now properly opens when the visualization is expanded (CAT-1133)
  • The plot controls drawer no longer blocks scrolling outside of its container and stays aligned with the container if the user does scroll. (CAT-1134)

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-1131
https://hms-dbmi.atlassian.net/browse/CAT-1133
https://hms-dbmi.atlassian.net/browse/CAT-1134

Testing

Manual testing, see video below.

Screenshots/Video

Screen.Recording.2025-02-06.134440.mp4

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

Please specify any additional information or context relevant to this PR.

Comment on lines 1 to 3
- Fix plot controls drawer positioning and scroll issues.
- Fix plot controls drawer not appearing when visualization is expanded.
- Improve position of metadata value bars.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the entries to reference cell pop?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@NickAkhmetov NickAkhmetov merged commit d6f67a8 into main Feb 6, 2025
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/another-batch-of-cellpop branch February 6, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants