Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-1074 Fix protected datasets bug #3682

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

austenem
Copy link
Collaborator

@austenem austenem commented Feb 5, 2025

Summary

Fix bug allowing non-public datasets to be added to workspaces.

Design Documentation/Original Tickets

CAT-1074 Jira ticket

Testing

Tested by attempting to add various combinations of public and non-public datasets from the search page to a workspace.

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was handling non-protected, non-public access levels such as 'consortium'?

@austenem austenem merged commit ab4bbe0 into main Feb 6, 2025
8 checks passed
@austenem austenem deleted the austenem/cat-1074-fix-protected-datasets-bug branch February 6, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants