Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-1118 Check for missing symlinks #3678

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

austenem
Copy link
Collaborator

@austenem austenem commented Feb 3, 2025

Summary

Adds checks before trying to access a workspace's symlinked files (resolves 2023 workspaces API bug that resulted in malformed workspaces with empty current_workspace_details objects).

Design Documentation/Original Tickets

CAT-1118 Jira ticket

Testing

Was able to reproduce the original error by calling isWorkspaceAtDatasetLimit on a workspace with a manually deleted current_workspace_details object, and used the same method to confirm that the issue was resolved by this fix.

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

@austenem austenem requested a review from john-conroy February 3, 2025 18:08
@austenem austenem merged commit 06c86bc into main Feb 3, 2025
8 checks passed
@austenem austenem deleted the austenem/cat-1118-check-for-missing-symlinks branch February 3, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants