Austenem/CAT-1085 Add sample workspace banner #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
reviewed
Feb 3, 2025
| } | ||
|
|
||
| return isAuthenticated ? ( | ||
| <IconPanel status="info"> |
There was a problem hiding this comment.
I understand this is pre-existing, but the language in the two panels outside of the login prompt is very similar. Is there a meaningful difference or can we conform them?
There was a problem hiding this comment.
I think we can conform them pretty easily, and that definitely cleans up this function.
john-conroy
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an info banner to template pages without sample workspaces.
Design Documentation/Original Tickets
CAT-1085 Jira ticket
Screenshots/Video
Local:
Prod:
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.