Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-1122, CAT-1123, CAT-1125, CAT-1126 Cellpop Fixes #3676

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

This PR contains fixes for several cellpop issues which were identified during QA testing.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-1122
https://hms-dbmi.atlassian.net/browse/CAT-1123
https://hms-dbmi.atlassian.net/browse/CAT-1125
https://hms-dbmi.atlassian.net/browse/CAT-1126

Testing

Manually tested.

Screenshots/Video

CAT-1122 - fixed Azimuth link, removed period from inside link.
image

The other fixes were made upstream and published in cellpop 0.0.8.

CAT-1123 - Fixed cellpop crash which occured from changing row visibility while another row is expanded. Also implemented behavior to control expand/hide behavior:

  • Expanding a hidden row now marks the row as visible
  • Hiding an expanded row now collapses the row
Screen.Recording.2025-02-03.102745.mp4

CAT-1125 - Fixed Heatmap Normalization label line overlapping with label.
image

CAT-1126 - Fix overlap between violins on charts with few datasets

image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

Please specify any additional information or context relevant to this PR.

@NickAkhmetov NickAkhmetov merged commit 71f79dc into main Feb 3, 2025
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/more-cellpop-fixes branch February 3, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants