Правда или действие #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/form.js
Outdated
Comment on lines
9
to
12
| COMMENT_MAXLENGTH_ERROR: `Максимальная длина комментария ${COMMENT_MAXLENGTH} символов`, | ||
| HASHTAG_MAXLENGTH_ERROR: `Максимальная длина хэштега ${HASHTAG_MAXLENGTH} символов`, | ||
| HASHTAG_COUNT_ERROR: `Нельзя указать больше ${HASHTAGS_MAXQUANTITY} хэштегов`, | ||
| INVALID_HASHTAG_STRING: 'Хэштег должен начинаться с #, состоять из букв и чисел без пробелов и не может состоять только из одной решётки', |
There was a problem hiding this comment.
константы получаемые на основе других значений именуем в camelCase.
В данном случае в виде словаря
const errorMessage = {
commentMaxLenght: `Максимальная длина комментария ${COMMENT_MAXLENGTH} символов`,
};
js/form.js
Outdated
| const onFormSubmit = (evt) => { | ||
| evt.preventDefault(); | ||
| pristine.validate(); | ||
| } |
js/form.js
Outdated
| pristine.addValidator(commentTextarea, validateComment, errorHashtagMessages.COMMENT_MAXLENGTH_ERROR); | ||
|
|
||
| // Валидация хештегов | ||
| const getHashtags = (value) => value.toLowerCase().trim().split(' '); |
There was a problem hiding this comment.
будет некорректно работать, например в таких случаях: #ffff #4444 #dfgddfk
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
Kartaviy-arteom
approved these changes
Feb 3, 2025
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Правда или действие
💥 https://htmlacademy-javascript.github.io/1582959-kekstagram-2/11/