Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

longs? #35

Open
Ironholds opened this issue Jan 16, 2017 · 5 comments
Open

longs? #35

Ironholds opened this issue Jan 16, 2017 · 5 comments

Comments

@Ironholds
Copy link
Collaborator

The codebase now includes those. Do we have that supported, R-side?

@hrbrmstr
Copy link
Owner

"those"?

@hrbrmstr
Copy link
Owner

oh, "longs". perhaps a bit more exposition might help clarify the question for me.

@Ironholds
Copy link
Collaborator Author

Oop, yep. So we have a lot of functions returning say std::vector < std::long > ... or accepting those as arguments. Do we have R-side support uniformly for that? I wasn't aware base was now cool with longs as a general thing.

@hrbrmstr
Copy link
Owner

hrbrmstr commented Jan 16, 2017

As long as it isn't an unsigned long, aye.

is.integer(2147483647L)
## TRUE

is.integer(4294967295L)
## FALSE

(I did not test that everywhere)

which means we may need to re-think the params/returns since IPv4 conversions are going to beed the full unsigned space.

@Ironholds
Copy link
Collaborator Author

Mmmn yeah. Would using doubles make more sense/give us enough space? Also means we can build in the NA support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants