Huawei grid charger usability fixes #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
schlimmchen
commented
Jan 23, 2025
schlimmchen
commented
- Fetching CAN messages (from the MCP2515) is very time critical. Attempt to miss less (hopefully none at all) messages.
- Stop caching new values for too long. Restore the previous trigger to push the values up to higher software levels.
- Send a request for data immediately after sending a parameter, allowing to update the PSU values in a timely manner.
we really need to be quick in retrieving CAN messages when the MCP2515 signals its interrupt. we therefore increase the hardware interface task's priority, so it is even higher priority than the Async TCP task. more importantly, we need to ask the scheduler to preempt a low-priority task and schedule the hardware interface task immediately, so we can retrieve the CAN messages in time.
the previous implementaton by MalteSchm relied that the 0x81 output current value was always the last one to be received. afterwards the data would be pushed upwards the stack. I did not like that, as I think that the values can potentially arrive in arbitrary order, as they are encoded with a type for a reason. in practice, that is probably not the case. waiting to push the collected values up the stack until a new request is sent has a significant drawback: once the values arrive at higher software levels, they are already <poll interval> seconds old. for that reason, I decided to restore the previous logic, where the output current value triggers the completion of collecting values. however, as a fall-back, the cached values are also pushed in case there are still some when we send a new request.
after sending new parameters, immediately send a new request to poll the new parameters, allowing to update the web UI in particular.
AndreasBoehm
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.