Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show mqtt battery live view card #1542

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Feature: show mqtt battery live view card #1542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions include/BatteryStats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,5 @@ class MqttBatteryStats : public BatteryStats {
// we do NOT publish the same data under a different topic.
void mqttPublish() const final { }

void getLiveViewData(JsonVariant& root) const final;

bool supportsAlarmsAndWarnings() const final { return false; }
};
9 changes: 0 additions & 9 deletions src/BatteryStats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,6 @@ void BatteryStats::getLiveViewData(JsonVariant& root) const
root["showIssues"] = supportsAlarmsAndWarnings();
}

void MqttBatteryStats::getLiveViewData(JsonVariant& root) const
{
// as we don't want to repeat the data that is already shown in the live data card
// we only add the live view data here when the discharge current limit can be shown
if (isDischargeCurrentLimitValid()) {
BatteryStats::getLiveViewData(root);
}
}

void PylontechBatteryStats::getLiveViewData(JsonVariant& root) const
{
BatteryStats::getLiveViewData(root);
Expand Down
Loading