Fix unwanted model retention when using class methods from Turbo::Broadcastable with locals
#710
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oadcastable` with locals
Consider the following model:
```ruby
class MyModel < ApplicationRecord
broadcasts locals: { something_static: true }
end
```
When broadcasting for the first time without this fix, Broadcastable
does something like:
```
{ something_static }.reverse_merge!(my_model: #<MyModel: id=1>)
```
On the second broadcast for another model instance, the reverse merge
will be a no-op, because the first model is already in the Hash!
Switching to a non-destructive `reverse_merge` resolves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following model:
When broadcasting for the first time without this fix, Broadcastable does something like:
On the second broadcast for another model instance, the reverse merge will be a no-op, because the first model is already in the Hash!
Switching to a non-destructive
reverse_mergeresolves the issue.