Skip to content

Commit

Permalink
fix: fail silently if error
Browse files Browse the repository at this point in the history
  • Loading branch information
pxseu committed Jul 29, 2022
1 parent 09419fb commit bff274c
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions src/commands/update/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,33 @@ pub async fn check_version(beta: bool) -> (bool, String) {
.get(RELEASE_URL)
.send()
.await
.expect("Failed to get latest release")
.expect("Failed to get latest release");

if !response.status().is_success() {
log::debug!(
"Failed to get latest release from Github: {}",
response.status()
);
// silently fail if we can't get the latest release
return (false, "".to_string());
}

let data = response
.json::<Vec<GithubRelease>>()
.await
.expect("Failed to parse latest release");

let latest = if beta {
// the latest release that can be prereleased
response
data
.iter()
// skip drafts
.find(|r| !r.draft)
.map(|r| r.tag_name.clone())
.expect("No release found")
} else {
// the latest release that is not prereleased
response
data
.iter()
// skip drafts and prereleases
.find(|r| !r.prerelease && !r.draft)
Expand Down

0 comments on commit bff274c

Please sign in to comment.