Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trailing-slash): handle HEAD request in trailing slash middleware #4049

Merged

Conversation

sushichan044
Copy link
Contributor

@sushichan044 sushichan044 commented Apr 3, 2025

The author should do the following, if applicable

closes #4048

Caution

Review should be done on a per-commit basis as test cases were refactored in 808e520
Hiding whitespace is also recommended.

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@sushichan044 sushichan044 changed the title fix: trailing slash middleware should handle HEAD request. feat: handle HEAD request in trailing slash middleware Apr 3, 2025
@sushichan044 sushichan044 marked this pull request as ready for review April 3, 2025 14:24
@sushichan044 sushichan044 force-pushed the fix/trailing-slash-mw-should-handle-head branch from a0a9782 to 9403842 Compare April 8, 2025 16:42
@sushichan044 sushichan044 changed the title feat: handle HEAD request in trailing slash middleware fix: handle HEAD request in trailing slash middleware Apr 8, 2025
@sushichan044
Copy link
Contributor Author

sushichan044 commented Apr 8, 2025

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (882e75a) to head (9403842).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4049   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         168      168           
  Lines       10684    10689    +5     
  Branches     3032     3023    -9     
=======================================
+ Hits         9757     9762    +5     
  Misses        926      926           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sushichan044 sushichan044 changed the title fix: handle HEAD request in trailing slash middleware fix(trailing-slash): handle HEAD request in trailing slash middleware Apr 9, 2025
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Hey @sushichan044 !

Looks good to me. I'll merge this into the main and release a new version later. Thank you!

@yusukebe yusukebe merged commit 02377ef into honojs:main Apr 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trailing-slash middleware should handle HEAD request
2 participants