Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): add props to ExecutionContext #4030

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Mar 30, 2025

Fixes #4022

This seems to be a new feat, but it is slight and just for support of Wrangler 4.x, so I labeled it a fix.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

This comment has been minimized.

Copy link

Bundle size check

main (0bb821a) #4030 (0396a71) +/-
Bundle Size (B) 18,976B 18,976B 0B
Bundle Size (KB) 18.53K 18.53K 0K

Compiler Diagnostics

main (0bb821a) #4030 (0396a71) +/-
Files 261 261 0
Lines 116,441 116,446 5
Identifiers 114,439 114,440 1
Symbols 303,843 303,844 1
Types 214,833 214,833 0
Instantiations 3,091,594 3,091,594 0
Memory used 448,342K 444,446K -3,896K
I/O read 0.03s 0.03s 0s
I/O write 0s 0s 0s
Parse time 0.66s 0.66s 0s
Bind time 0.26s 0.28s 0.02s
Check time 5.88s 5.51s -0.37s
Emit time 0s 0s 0s
Total time 6.8s 6.45s -0.35s

Reported by octocov

Copy link

codecov bot commented Mar 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (0bb821a) to head (b6002cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4030   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         168      168           
  Lines       10768    10769    +1     
  Branches     3070     3020   -50     
=======================================
+ Hits         9830     9831    +1     
  Misses        937      937           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe marked this pull request as draft March 30, 2025 10:01
@yusukebe
Copy link
Member Author

This may introduce a breaking change for ExecutionContext, so I have made this PR a draft now.

@hmnd
Copy link

hmnd commented Mar 31, 2025

@yusukebe Thanks for working on this! I'm also seeing a missing exports prop:
image

Unhelpfully, its type in @cloudflare/workers-types is any...

Update: Just noticed I was importing from /experimental, so exports is not yet in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrangler 4.x Support
2 participants