Fix Supervisor image corruption detection #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple images match the reference, multiple IDs are passed as a single argument to docker image rm, leading to an error: Error response from daemon: page not found Make sure to pass the ids as separate argument to make the delete work in any case.
As noted in #2113, we don't need this logic anymore after a major OS releases. So simply drop the logic to also make the image corruption detection work again.
|
Docker might return image IDs in random order, with that uniq doesn't work. While it shouldn't hurt, it can lead to confusing errors, e.g. |
sairon
approved these changes
Nov 30, 2023
agners
added a commit
that referenced
this pull request
Dec 4, 2023
* Fix Supervisor image corruption detection When multiple images match the reference, multiple IDs are passed as a single argument to docker image rm, leading to an error: Error response from daemon: page not found Make sure to pass the ids as separate argument to make the delete work in any case. * Cleanup reusing Supervisor from an old/unused reference As noted in #2113, we don't need this logic anymore after a major OS releases. So simply drop the logic to also make the image corruption detection work again. * Make sure image IDs are sorted to make them unique
darkxst
pushed a commit
to darkxst/ha-operating-system
that referenced
this pull request
Dec 9, 2023
* Fix Supervisor image corruption detection When multiple images match the reference, multiple IDs are passed as a single argument to docker image rm, leading to an error: Error response from daemon: page not found Make sure to pass the ids as separate argument to make the delete work in any case. * Cleanup reusing Supervisor from an old/unused reference As noted in home-assistant#2113, we don't need this logic anymore after a major OS releases. So simply drop the logic to also make the image corruption detection work again. * Make sure image IDs are sorted to make them unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple images match the reference, multiple IDs are passed as a
single argument to docker image rm, leading to an error:
Error response from daemon: page not found
Make sure to pass the ids as separate argument to make the delete work
in any case.
While at it, as noted in #2113, we don't need this logic anymore after a major OS
releases. So simply drop the logic to also make the image corruption
detection work again.