-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up inconsistencies in kernel configs #2923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up all kernel configs and fragments from non-existing kernel options, invalid choice values and choices that trigger warnings during kernel package configuration. Here's an example of warnings triggered for Yellow: .config:8531:warning: override: MODULE_COMPRESS_NONE changes choice state .config:8536:warning: override: ZSWAP_COMPRESSOR_DEFAULT_LZ4 changes choice state .config:8537:warning: override: ZSWAP_ZPOOL_DEFAULT_ZSMALLOC changes choice state .config:8543:warning: override: CPU_FREQ_DEFAULT_GOV_ONDEMAND changes choice state .config:8717:warning: override: reassigning to symbol CGROUP_HUGETLB .config:8767:warning: symbol value 'm' invalid for XFRM .config:8852:warning: symbol value 'm' invalid for MEDIA_CONTROLLER_DVB .config:8972:warning: symbol value 'm' invalid for SND_HDA_I915 There were also some options that are set in our or default configs but end up patched by `KCONFIG_(DIS|EN)ABLE_OPT` in package makefiles, these options are now explicitly set in our fragments too. For example this was toggled for `generic_aarch64`: CONFIG_DEFAULT_SECURITY_APPARMOR n -> y CONFIG_DEFAULT_SECURITY_DAC y -> n CONFIG_GCC_PLUGINS y -> n The only goal of this commit is to make sure no warnings appear anymore and the resulting kernel configs remain unchanged. This will allow us to create tools for sanity checks of our kernel config overrides. There is one single change in `ova` config resulting from previously invalid `m` option for a bool value: -# CONFIG_9P_FS_POSIX_ACL is not set +CONFIG_9P_FS_POSIX_ACL=y
For tinker and amlogic-based targets we're using checked-in kernel configs generated by kconfig for some old kernel revisions. Check in current config before we clean it up and reduce to a smaller stub later.
sairon
added
board/raspberrypi
Raspberry Pi Boards
board/ova
Open Virtual Appliance (Virtual Machine)
board/odroid
Hardkernel's ODROID Boards
intel-nuc
Intel NUC (merged to generic-x86-64)
board/tinker
ASUS' Tinker Boards
linux
Linux kernel related issue
board/generic-x86-64
Generic x86-64 Boards (like Intel NUC)
board/khadas
Khadas VIM Boards
board/yellow
Home Assistant Yellow
board/generic-aarch64
Generic aarch64 machine
labels
Nov 13, 2023
agners
reviewed
Nov 13, 2023
agners
approved these changes
Nov 14, 2023
sairon
added a commit
that referenced
this pull request
Nov 14, 2023
Reduce fully-expanded configs versioned in our repository to defconfigs containing only the necessary options. Just like #2923, this change does not alter the resulting kernel .config in any way for the affectedt platforms (Tinker, Odroid C2/C4/N2).
sairon
added a commit
that referenced
this pull request
Nov 14, 2023
Reduce fully-expanded configs versioned in our repository to defconfigs containing only the necessary options. Just like #2923, this change does not alter the resulting kernel .config in any way for the affected platforms (Tinker, Odroid C2/C4/N2).
sairon
added a commit
that referenced
this pull request
Nov 14, 2023
Reduce fully-expanded configs versioned in our repository to defconfigs containing only the necessary options. Just like #2923, this change does not alter the resulting kernel .config in any way for the affected platforms (Tinker, Odroid C2/C4/N2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
board/generic-aarch64
Generic aarch64 machine
board/generic-x86-64
Generic x86-64 Boards (like Intel NUC)
board/khadas
Khadas VIM Boards
board/odroid
Hardkernel's ODROID Boards
board/ova
Open Virtual Appliance (Virtual Machine)
board/raspberrypi
Raspberry Pi Boards
board/tinker
ASUS' Tinker Boards
board/yellow
Home Assistant Yellow
cla-signed
intel-nuc
Intel NUC (merged to generic-x86-64)
linux
Linux kernel related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up all kernel configs and fragments from non-existing kernel options, invalid choice values and choices that trigger warnings during kernel package configuration.
Here's an example of warnings triggered for Yellow:
There were also some options that are set in our or default configs but end up patched by
KCONFIG_(DIS|EN)ABLE_OPT
in package makefiles, these options are now explicitly set in our fragments too. For example this was toggled forgeneric_aarch64
:The only goal of this commit is to make sure no warnings appear anymore and the resulting kernel configs remain unchanged. This will allow us to create tools for sanity checks of our kernel config overrides. There is one single change in
ova
config resulting from previously invalidm
option for a bool value: