Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laifen #6460

Merged
merged 29 commits into from
Feb 7, 2025
Merged

Laifen #6460

merged 29 commits into from
Feb 7, 2025

Conversation

UrbanTechIO
Copy link
Contributor

@UrbanTechIO UrbanTechIO commented Jan 29, 2025

Proposed change

Adding Link to the Laifen custom Integration
https://github.com/UrbanTechIO/Laifen

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've currently added product photos but this repo collects branding logos, so I would expect you to add the logo and icon of laifen. Also missing a link to your custom integration

./Klaas

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 31, 2025 22:49
@UrbanTechIO
Copy link
Contributor Author

UrbanTechIO commented Feb 1, 2025

@klaasnicolaas My apologies, this is the first time i am doing this, I have updated the icon and logo to meet the requirements, and added the link to my custom integration.

@UrbanTechIO UrbanTechIO marked this pull request as ready for review February 1, 2025 15:56
@UrbanTechIO
Copy link
Contributor Author

Hello @klaasnicolaas, any chance of getting a bit of your time to review the changes?, thanks.

@frenck
Copy link
Member

frenck commented Feb 6, 2025

Hello @klaasnicolaas, any chance of getting a bit of your time to review the changes?, thanks.

Please don't ping for reviews. There are almost a thousand PRs in this org, that all want their stuff merged. Please have a little patience.

../Frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logos used seem to differ from what the manufacturer is using for their branding on their website:

CleanShot 2025-02-06 at 18 19 36

Please make sure the branding is unmodified.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft February 6, 2025 17:21
@UrbanTechIO UrbanTechIO marked this pull request as ready for review February 7, 2025 08:40
@home-assistant home-assistant bot requested a review from frenck February 7, 2025 08:40
@UrbanTechIO
Copy link
Contributor Author

Hello @klaasnicolaas, any chance of getting a bit of your time to review the changes?, thanks.

Please don't ping for reviews. There are almost a thousand PRs in this org, that all want their stuff merged. Please have a little patience.

../Frenck

Got it, thanks for pointing out, I have modified the logos according to company branding

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @UrbanTechIO 👍

../Frenck

@frenck frenck dismissed klaasnicolaas’s stale review February 7, 2025 10:25

Comment addressed

@frenck frenck merged commit 56e87cb into home-assistant:master Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants