ALS-8239: Fix PFB encoding issues #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ramari16
commented
Jan 31, 2025
ramari16
commented
- Update the query result methods to not convert responses to strings, which was breaking the encoding of binary files
srpiatt
reviewed
Jan 31, 2025
| @@ -240,7 +240,13 @@ public Response queryResult(String rsURL, String queryId, QueryRequest queryRequ | |||
| HttpClientUtil.composeURL(rsURL, pathName), createHeaders(queryRequest.getResourceCredentials()), body | |||
| ); | |||
|
|
|||
| String content = httpClientUtil.readObjectFromResponse(resourcesResponse); | |||
| byte[] content = httpClientUtil.readBytesFromResponse(resourcesResponse); | |||
| FileOutputStream fos = new FileOutputStream("/tmp/test.avro"); | |||
There was a problem hiding this comment.
Do we want this (/tmp/test.avro) hardcoded in this file? If yes, can we move it to the top of the class/file?
There was a problem hiding this comment.
Bahhh, this was for debugging. I'll remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.