Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALS-0000] Checkmarx Fix - Check domain of proxy request #159

Merged
merged 1 commit into from
Nov 20, 2023
Merged

[ALS-0000] Checkmarx Fix - Check domain of proxy request #159

merged 1 commit into from
Nov 20, 2023

Conversation

Luke-Sikina
Copy link
Member

  • We don't want an attacker leveraging the proxy client to make requests to 3rd party domains
  • At the moment, this is just intended for docker containers in the same network, so I just made a regex that restricts the host to reasonable container names

@Luke-Sikina Luke-Sikina force-pushed the checkmarx-was-right-i-am-in-shambles branch 2 times, most recently from cad2bda to a9f786a Compare November 20, 2023 18:02
[ALS-0000] Checkmarx Fix - Check domain of proxy request
c152141 
- We don't want an attacker leveraging the proxy client
to make requests to 3rd party domains
- At the moment, this is just intended for docker containers in the
same network, so I just made a regex that restricts the host to
reasonable container names
@Luke-Sikina Luke-Sikina force-pushed the checkmarx-was-right-i-am-in-shambles branch from a9f786a to c152141 Compare November 20, 2023 18:08
@Luke-Sikina Luke-Sikina merged commit 6d602c9 into release/0006 Nov 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Luke-Sikina