DTSCCI-893 Moved variable from instance to method level to prevent po…

…tential concurrency issue (#1496)

Co-authored-by: kdaHMCTS <128375235+kdaHMCTS@users.noreply.github.com>

src/main/java/uk/gov/hmcts/reform/civil/service/AuthorisationService.java

@@ -23,8 +23,6 @@ public class AuthorisationService {
 
     private final IdamClient idamClient;
 
-    private UserInfo userInfo;
-
     public Boolean authoriseService(String serviceAuthHeader) {
         String callingService;
         try {
@@ -45,7 +43,7 @@ public Boolean authoriseService(String serviceAuthHeader) {
 
     public Boolean authoriseUser(String authorisation) {
         try {
-            userInfo = idamClient.getUserInfo(authorisation);
+            UserInfo userInfo = idamClient.getUserInfo(authorisation);
             if (null != userInfo) {
                 return true;
             }
@@ -56,10 +54,6 @@ public Boolean authoriseUser(String authorisation) {
         return false;
     }
 
-    public UserInfo getUserInfo() {
-        return this.userInfo;
-    }
-
     public boolean isServiceAndUserAuthorized(String authorisation, String s2sToken) {
         return Boolean.TRUE.equals(authoriseUser(authorisation))
             && Boolean.TRUE.equals(authoriseService(s2sToken));