PR for v.1.9.0 #189
Merged
PR for v.1.9.0 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns.border_radius property.
…arsed by .from_js_literal(). Closes #185.
| left_value = validators.string(left_value, allow_empty = False) | ||
| right_value = validators.string(right_value, allow_empty = False) | ||
|
|
||
| return left_value + right_value |
There was a problem hiding this comment.
Whatever the operator +, -, / in the expression, you apply the + operation, it's super confusing.
Shouldn't + be the only operator accepted on strings ?
'hello' - 'bye' and 'hello' / 'bye' are both unsupported operand on str in Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChartEvents.render.utility_classes.data_labels.PieDataLabelclass to ensure support forthe
.distanceproperty on Pie-chart (and descended) data labels. Closesdistancekeyword fordata_labelshas no effect in pie charts #183.options.chart.heighttype validation to accept string values as per JS API.(Issue reported in Missing keywords for Sunburst chart #184).
options.plot_options.sunburst.SunburstOptions.border_radius(issue reported in Missing keywords for Sunburst chart #184).
+operator in JS literal strings when parsed by.from_js_literal(). Closes JS literal containing+for string concatenation breaksfrom_js_literal()#185.utility_classes.border_radius.BorderRadiusobject.