Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lacucinaitaliana.it and lacucinaitaliana.com #1456

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

fabrice1236
Copy link
Contributor

This adds support for both the italian and english websites of La Cucina Italiana. Both sites use the Recipe Schema, but I still hardcoded the author, as the site only returns "Redazione" on the italian website and "Editorial staff" on the english website.

@hhursev
Copy link
Owner

hhursev commented Jan 6, 2025

Can you please run the pre-commit hooks and also reorder the JSON keys as instructed in the CI:

To automatically reorder the keys, run the following command:
python scripts/reorder_json_keys.py

lgtm and I'd like to merge

@fabrice1236
Copy link
Contributor Author

Whoops, fixed it. Tests are now successful on my end.

@hhursev
Copy link
Owner

hhursev commented Jan 6, 2025

Yes they are :)

@hhursev hhursev merged commit 5200083 into hhursev:main Jan 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants