Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for quakeroats.com #1417

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rilical
Copy link

@rilical rilical commented Dec 4, 2024

This pull request adds a new scraper for recipes hosted on quakeroats.com. The scraper is implemented as a subclass of AbstractScraper and supports extracting the following recipe details:

  • Title
  • Author
  • Total Time
  • Ingredients (with accurate quantities)
  • Instructions
  • Description
  • Image URL
  • Language

Changes Made

  • Added QuakerOats scraper in recipe_scrapers/quakeroats.py.
  • Implemented logic for extracting ingredient groups where applicable.
  • Enhanced parsing to include accurate ingredient quantities and step-by-step instructions.
  • Created and updated test cases:
    • Added test JSON and HTML under tests/test_data/quakeroats.com.
    • Updated expected outputs in the test JSON file to reflect the actual website structure.
  • Fixed issues with encoding to properly handle special characters in recipe text.

Test Results

All tests pass successfully, verifying the scraper's accuracy and compatibility. Outputs for recipes from quakeroats.com have been manually validated to match the expected results.

Future Enhancements

  • Monitor for any changes to the quakeroats.com HTML structure and update the scraper as needed.
  • Add support for additional optional fields like ratings and yields if they become available.

@rilical rilical marked this pull request as draft December 4, 2024 05:19
@rilical rilical marked this pull request as ready for review December 4, 2024 05:20
@rilical
Copy link
Author

rilical commented Dec 9, 2024

@jknndy Hello, can you please run check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant