refactor: rename var and add doc

hhow09 · Jan 23, 2025 · 26239ae · 26239ae
1 parent b807559
commit 26239ae
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/backend/src/math/evaluate.ts b/backend/src/math/evaluate.ts
@@ -37,6 +37,7 @@ function evaluate(s: string): string {
     if (!first) {
         return "0"
     }
+    // early return
     if (exps.length === 0) {
         return first.evaluate()
     }

diff --git a/backend/src/math/types.ts b/backend/src/math/types.ts
@@ -77,15 +77,15 @@ export class Fraction {
     }
 
     public add(f: Fraction): Fraction {
-        const lcm = getLcm(this.denominator, f.denominator);
-        const multiplyThis = lcm.div(this.denominator);
-        const multiplyF = lcm.div(f.denominator);
+        const commonDenominator = getLcm(this.denominator, f.denominator);
+        const multiplyThis = commonDenominator.div(this.denominator);
+        const multiplyF = commonDenominator.div(f.denominator);
         this.numerator = this.numerator.mul(multiplyThis);
-        this.denominator = lcm;
+        this.denominator = commonDenominator;
         f.numerator = f.numerator.mul(multiplyF);
-        f.denominator = lcm;
+        f.denominator = commonDenominator;
         const sum = this.numerator.add(f.numerator);
-        return new Fraction(sum, lcm);
+        return new Fraction(sum, commonDenominator);
     }
 
     public evaluate(): string {