Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites logic for Conjured Items and Backstage Passes #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rewrites logic for Conjured Items and Backstage Passes #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
175 changes: 130 additions & 45 deletions gilded_rose/lib/gilded_rose.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,52 +7,126 @@ defmodule GildedRose do
Enum.map(items, &update_item/1)
end

def update_item(%{name: "Backstage passes to a TAFKAL80ETC concert"} = item) do
item
|> change_quality()
|> change_sell_in()
end

def update_item(%{name: "Conjured Item"} = item) do
item
|> change_quality()
|> change_sell_in()
end

defp change_quality(%{name: "Conjured Item", quality: quality, sell_in: sell_in} = item)
when sell_in <= 0 do
decrease_quality(item, 4)
end

defp change_quality(%{name: "Conjured Item", quality: quality, sell_in: sell_in} = item) do
decrease_quality(item, 2)
end

defp change_quality(
%{name: "Backstage passes to a TAFKAL80ETC concert", quality: quality, sell_in: sell_in} =
item
) do
cond do
item.sell_in > 10 ->
increase_quality(item, 1)

item.sell_in > 5 ->
increase_quality(item, 2)

item.sell_in > 0 ->
increase_quality(item, 3)

true ->
decrease_quality(item, quality)
end
end

defp decrease_quality(item, n) do
%{item | quality: max(item.quality - n, 0)}
end

defp increase_quality(item, n) do
%{item | quality: min(item.quality + n, 50)}
end

defp change_sell_in(item) do
%{item | sell_in: item.sell_in - 1}
end

def update_item(item) do
item = cond do
item.name != "Aged Brie" && item.name != "Backstage passes to a TAFKAL80ETC concert" ->
if item.quality > 0 do
if item.name != "Sulfuras, Hand of Ragnaros" do
%{item | quality: item.quality - 1}
item =
cond do
item.name != "Aged Brie" && item.name != "Backstage passes to a TAFKAL80ETC concert" ->
if item.quality > 0 do
if item.name != "Sulfuras, Hand of Ragnaros" do
%{item | quality: item.quality - 1}
else
item
end
else
item
end
else
item
end
true ->
cond do
item.quality < 50 ->
item = %{item | quality: item.quality + 1}
cond do
item.name == "Backstage passes to a TAFKAL80ETC concert" ->
item = cond do
item.sell_in < 11 ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}
true -> item
end
true -> item
end
cond do
item.sell_in < 6 ->

true ->
cond do
item.quality < 50 ->
item = %{item | quality: item.quality + 1}

cond do
item.name == "Backstage passes to a TAFKAL80ETC concert" ->
item =
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}
true -> item
item.sell_in < 11 ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}

true ->
item
end

true ->
item
end
true -> item
end
true -> item
end
true -> item
end
end
item = cond do
item.name != "Sulfuras, Hand of Ragnaros" ->
%{item | sell_in: item.sell_in - 1}
true -> item
end

cond do
item.sell_in < 6 ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}

true ->
item
end

true ->
item
end

true ->
item
end

true ->
item
end
end

item =
cond do
item.name != "Sulfuras, Hand of Ragnaros" ->
%{item | sell_in: item.sell_in - 1}

true ->
item
end

cond do
item.sell_in < 0 ->
cond do
Expand All @@ -64,20 +138,31 @@ defmodule GildedRose do
cond do
item.name != "Sulfuras, Hand of Ragnaros" ->
%{item | quality: item.quality - 1}
true -> item

true ->
item
end
true -> item

true ->
item
end
true -> %{item | quality: item.quality - item.quality}

true ->
%{item | quality: item.quality - item.quality}
end

true ->
cond do
item.quality < 50 ->
%{item | quality: item.quality + 1}
true -> item

true ->
item
end
end
true -> item

true ->
item
end
end
end
3 changes: 2 additions & 1 deletion gilded_rose/mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ defmodule GildedRose.MixProject do
[
app: :gilded_rose,
version: "0.1.0",
elixir: "~> 1.8",
elixir: "~> 1.6",
start_permanent: Mix.env() == :prod,
deps: deps()
]
Expand All @@ -21,6 +21,7 @@ defmodule GildedRose.MixProject do
# Run "mix help deps" to learn about dependencies.
defp deps do
[
{:mix_test_watch, "~> 0.8", only: :dev, runtime: false}
# {:dep_from_hexpm, "~> 0.3.0"},
# {:dep_from_git, git: "https://github.com/elixir-lang/my_dep.git", tag: "0.1.0"}
]
Expand Down
4 changes: 4 additions & 0 deletions gilded_rose/mix.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
%{
"file_system": {:hex, :file_system, "0.2.7", "e6f7f155970975789f26e77b8b8d8ab084c59844d8ecfaf58cbda31c494d14aa", [:mix], [], "hexpm"},
"mix_test_watch": {:hex, :mix_test_watch, "0.9.0", "c72132a6071261893518fa08e121e911c9358713f62794a90c95db59042af375", [:mix], [{:file_system, "~> 0.2.1 or ~> 0.3", [hex: :file_system, repo: "hexpm", optional: false]}], "hexpm"},
}