Skip to content

Commit

Permalink
fix: add eslint-config-hfreire + force release
Browse files Browse the repository at this point in the history
  • Loading branch information
hfreire committed Jul 24, 2017
1 parent ddc805c commit 0ef4f2c
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 43 deletions.
35 changes: 1 addition & 34 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,36 +1,3 @@
{
"extends": [
"standard"
],
"parser": "babel-eslint",
"plugins": [
"mocha",
"node"
],
"globals": {
"describe": true,
"it": true,
"expect": true,
"request": true,
"before": true,
"beforeEach": true,
"after": true,
"afterEach": true,
"mockery": true,
"sinon": true,
"td": true
},
"rules": {
"node/shebang": [
"error",
{
"convertPath": {
"src/app.js": [
"src/app.js",
"bin/app.js"
]
}
}
]
}
"extends": "eslint-config-hfreire"
}
11 changes: 6 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,24 @@
},
"devDependencies": {
"babel-cli": "6.24.1",
"babel-eslint": "7.2.3",
"babel-preset-es2015": "6.24.1",
"chai": "4.1.0",
"chai-as-promised": "7.1.1",
"coveralls": "2.13.1",
"eslint": "4.3.0",
"eslint-config-standard": "10.2.1",
"eslint-config-hfreire": "1.0.4",
"eslint-plugin-import": "2.7.0",
"eslint-plugin-json": "1.2.0",
"eslint-plugin-mocha": "4.11.0",
"eslint-plugin-node": "5.1.1",
"eslint-plugin-promise": "3.5.0",
"eslint-plugin-standard": "3.0.1",
"eslint-plugin-unicorn": "2.1.2",
"istanbul": "0.4.5",
"mocha": "3.4.2",
"semantic-release": "6.3.6",
"pre-git": "3.14.1",
"standard": "10.0.2",
"testdouble": "3.2.1"
"semantic-release": "6.3.6",
"testdouble": "3.2.2"
},
"config": {
"pre-git": {
Expand Down
4 changes: 2 additions & 2 deletions src/pollmommy.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-disable no-undef,no-useless-escape */

/*
* Copyright (c) 2017, Hugo Freire <hugo@exec.sh>.
*
Expand Down Expand Up @@ -50,7 +52,6 @@ class Pollmommy {
}

const evaluate = function (pollId, pollOptionId) {
/* eslint-disable */
var p = pollId
var a = pollOptionId + ','
var b = 1
Expand Down Expand Up @@ -132,7 +133,6 @@ class Pollmommy {
})
})
})
/* eslint-enable */
}

return vote.bind(this)(pollUrl, pollId, pollOptionId, evaluate)
Expand Down
2 changes: 1 addition & 1 deletion test/app.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-unused-vars */
/* eslint-disable no-unused-vars,unicorn/no-process-exit */

/*
* Copyright (c) 2017, Hugo Freire <hugo@exec.sh>.
Expand Down
4 changes: 3 additions & 1 deletion test/pollmommy.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-disable no-unused-expressions */

/*
* Copyright (c) 2017, Hugo Freire <hugo@exec.sh>.
*
Expand Down Expand Up @@ -85,7 +87,7 @@ describe('pollmommy', () => {
const _pollId = pollIdCaptor.value
const _pollOptionId = pollOptionIdCaptor.value

_evaluate.should.not.be.null // eslint-disable-line
_evaluate.should.not.be.null
_pollId.should.be.eql(pollId)
_pollOptionId.should.be.eql(pollOptionId)
})
Expand Down

0 comments on commit 0ef4f2c

Please sign in to comment.