Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warn when clipping, gen agent id once #38

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: warn when clipping, gen agent id once #38

merged 1 commit into from
Oct 11, 2024

Conversation

alemidev
Copy link
Member

@alemidev alemidev commented Oct 2, 2024

No description provided.

@alemidev alemidev added the tweak Code quality label Oct 2, 2024
@alemidev alemidev requested a review from ghyatzo October 2, 2024 22:22
ghyatzo
ghyatzo reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@ghyatzo ghyatzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clipping behavior was already present. Was this to just have print a warning?

ghyatzo
ghyatzo reviewed Oct 6, 2024
View reviewed changes
Copy link
Member

@ghyatzo ghyatzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the agent id.

zaaarf
zaaarf requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@zaaarf zaaarf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased onto dev. @alemidev should do it, to preserve authorship.

@alemidev alemidev requested a review from zaaarf October 11, 2024 18:41
@zaaarf zaaarf merged commit 306a687 into dev Oct 11, 2024
144 checks passed
@zaaarf zaaarf deleted the fix/op-clip branch October 11, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghyatzo ghyatzo ghyatzo left review comments

@zaaarf zaaarf zaaarf approved these changes

Assignees
No one assigned
Labels
tweak Code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alemidev @ghyatzo @zaaarf