fix: leave_workspace returns like detach #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alemidev
added
bug
alemidev
force-pushed
the
fix/workspace-leave-bool
branch
2 times, most recently
from
fa655af to
d371046
Compare
frelodev
approved these changes
Oct 1, 2024
alemidev
force-pushed
the
fix/workspace-leave-bool
branch
from
61c1691 to
6afbb23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously only returned
trueif Client held a workspace reference, now it returnstrueif last ref has been dropped, or no ref was being owned. If, while dropping, dangling refs are still present, it will returnfalse(just like detach method)