remove _.groupBy

hetalang · Nov 9, 2023 · 3176ce0 · 3176ce0
1 parent 3c4bb59
commit 3176ce0
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 11 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -56,6 +56,7 @@
           {"code": 100, "ignoreComments": true}
         ],
         "max-nested-callbacks": ["warn", 4],
-        "no-unused-vars": "warn"
+        "no-unused-vars": "warn",
+        "no-prototype-builtins": "off"
     }
 }
diff --git a/src/dbsolve-export/index.js b/src/dbsolve-export/index.js
@@ -236,11 +236,15 @@ class DBSolveExport extends AbstractExport{
           assignments
         };
       });
-    // group Const
-    let groupedConst = _.groupBy(
-      ns.selectByClassName('Const'),
-      (constant) => _get(constant, this.groupConstBy)
-    );
+    // group Const, instead of _.groupBy
+    let groupedConst = {}; // {group1: [const1, const2], group2: [const3, const4]}
+    ns.selectByClassName('Const').forEach((constant) => {
+      let key = _get(constant, this.groupConstBy) + '';
+      if (!groupedConst.hasOwnProperty(key)) {
+        groupedConst[key] = [];
+      }
+      groupedConst[key].push(constant);
+    });
 
     return {
       population: ns,

diff --git a/src/slv-export/index.js b/src/slv-export/index.js
@@ -221,11 +221,15 @@ class SLVExport extends AbstractExport{
       logger.error(msg, {type: 'ExportError'});
     }
 
-    // group Const
-    let groupedConst = _.groupBy(
-      ns.selectByClassName('Const'),
-      (con) => _get(con, this.groupConstBy)
-    );
+    // group Const, instead of _.groupBy
+    let groupedConst = {}; // {group1: [const1, const2], group2: [const3, const4]}
+    ns.selectByClassName('Const').forEach((constant) => {
+      let key = _get(constant, this.groupConstBy) + '';
+      if (!groupedConst.hasOwnProperty(key)) {
+        groupedConst[key] = [];
+      }
+      groupedConst[key].push(constant);
+    });
 
     return {
       population: ns,