feat(fd): implement fcntl(F_GETFL)
#1626
Open
+103
−69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
fcntl(F_GETFL)
in three steps:O_APPEND
andO_NONBLOCK
) fromOpenOptions
into a newfd::StatusFlags
type as per POSIX.ObjectInterface::ioctl(&self, cmd: IoCtl, value: bool)
withObjectInterface::set_status_flags(&self, status_flags: fd::StatusFlags)
, as that seems more straightforward for adding methods compared to adding more values toIoCtl
and handling those in the implementors.fcntl(F_GETFL)
by addingObjectInterface::status_flags(&self)
.This closes #1383.