-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't extract with korean language #1
Comments
It should be unicode (utf-8)? Are the names incorrect or the file contents? I'm not sure we touch the file contents (we export the binary file as is from the grf), but the file name may be being corrupted, I could check that. |
did you know how to make it utf-8? your source code just about extract right? did you know how to repack it to be .grf? |
Yep, this package only extracts files from grf. Are you extracting from linux or windows (although I'm not sure this matters). I believe you are having problems with the file names, right? When you open the file, the encoding is correct (assuming your text editor has the right encoding set)? Currently, when we parse the file name from the grf, here: https://github.com/herenow/grf-extractor/blob/master/lib/Loaders/GameFile.js#L196 We are reading byte by byte, and translating each byte to an ascii character, so we don't support unicode/utf-8. I could try to write a fix for this this week, if you are willing to test this out :) |
wow I really want to test it out.. but I guess we can't do that.. thanks anyway :) |
The text encoding of the file names is not UTF-8, it is EUC-KR. |
Apologies, it's actually CP949! |
even if I have korean grf
after I extract it will be ascii grf
can you fix it?
The text was updated successfully, but these errors were encountered: