Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't extract with korean language #1

Open
gandhyonly opened this issue Dec 30, 2016 · 6 comments
Open

can't extract with korean language #1

gandhyonly opened this issue Dec 30, 2016 · 6 comments

Comments

@gandhyonly
Copy link

even if I have korean grf
after I extract it will be ascii grf
can you fix it?

@herenow
Copy link
Owner

herenow commented Dec 30, 2016

It should be unicode (utf-8)? Are the names incorrect or the file contents?

I'm not sure we touch the file contents (we export the binary file as is from the grf), but the file name may be being corrupted, I could check that.

@gandhyonly
Copy link
Author

did you know how to make it utf-8?
I already extract it to your binary lang but it works fine..
I think that binary language have same mean with korean language..
but I need korean language because its more readable. I see your source code but I never to set something like korean language too. so I don't know how to fix it..
and If I know I will learn all your code before doing it T.T

your source code just about extract right? did you know how to repack it to be .grf?

@herenow
Copy link
Owner

herenow commented Jan 2, 2017

Yep, this package only extracts files from grf.

Are you extracting from linux or windows (although I'm not sure this matters).

I believe you are having problems with the file names, right? When you open the file, the encoding is correct (assuming your text editor has the right encoding set)?

Currently, when we parse the file name from the grf, here:

https://github.com/herenow/grf-extractor/blob/master/lib/Loaders/GameFile.js#L196

We are reading byte by byte, and translating each byte to an ascii character, so we don't support unicode/utf-8.

I could try to write a fix for this this week, if you are willing to test this out :)

@gandhyonly
Copy link
Author

wow I really want to test it out..
is there a way to repack it too?
so my plan is I want to create automatic website for custom grf :D
then I need your script to repack automatically..

but I guess we can't do that..
there's so much work to make it grf repack hahaha..

thanks anyway :)

@cmbasnett
Copy link

The text encoding of the file names is not UTF-8, it is EUC-KR.

@cmbasnett
Copy link

Apologies, it's actually CP949!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants